Skip to content

chore: migrate graalvm jobs to kokoro instance pool #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 18, 2024
Merged

chore: migrate graalvm jobs to kokoro instance pool #2023

merged 7 commits into from
Nov 18, 2024

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Nov 6, 2024 •
edited
Loading

Notable Changes:

  • Removed unused keystore settings.
  • Replaced use of TRAMPOLINE_IMAGE environment variable with container_properties { docker_image ...}}
  • Modified renovate bot settings to edit new docker_image property's value when a new version of java-shared-config is available.

@mpeddada1 mpeddada1 requested a review from a team as a code owner November 6, 2024 21:26
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 6, 2024
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 6, 2024

Removing the TRAMPOLINE_IMAGE is resulting in:

Traceback (most recent call last):
  File "/tmpfs/src/gfile/trampoline_v1.py", line 137, in 
    main()
  File "/tmpfs/src/gfile/trampoline_v1.py", line 125, in main
    image = os.environ['TRAMPOLINE_IMAGE']
  File "/usr/lib/python3.5/os.py", line 725, in __getitem__
    raise KeyError(key) from None
KeyError: 'TRAMPOLINE_IMAGE'
cleanup

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 12, 2024

After migrating to instance pools and re-running the kokoro jobs, the graalvm checks are not showing any logs and failing within 26s.

@mpeddada1 mpeddada1 closed this Nov 12, 2024
@mpeddada1 mpeddada1 reopened this Nov 12, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2024
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 18, 2024

Stacktrace:

See 'docker run --help'.
/b/f/w/src/gfile/trampoline_cleanup.sh: line 5: sudo: command not found

@mpeddada1 mpeddada1 merged commit 3453864 into main Nov 18, 2024
19 checks passed
@mpeddada1 mpeddada1 deleted the use-kokoro-instance branch November 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @burkedavison @yoshi-kokoro